Allow protocol variance errors at usage site or class definition #2172
+21
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changed protocol variance conformance tests to allow errors at either the class definition or the usage site (or both) for cases where the declared variance is wrong. The full discussion is here: #2171
Test plan:
I pinned the pre-existing versions of all the typecheckers because the versioning updates were generating too large of a change, which was muddying the PR. It seemed like a good idea to do the version updates as a separate change, but happy to change follow the latest versions if this is not ok
Results: